Skip to content

[main] Update dependencies from dotnet/arcade#8350

Merged
jaredpar merged 8 commits intomainfrom
darc-main-1a9de2c4-14e4-4198-949d-cd99f4699486
Mar 3, 2023
Merged

[main] Update dependencies from dotnet/arcade#8350
jaredpar merged 8 commits intomainfrom
darc-main-1a9de2c4-14e4-4198-949d-cd99f4699486

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 28, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: a0cb50dc-7d38-4a32-e166-08db18b91f66
  • Build: 20230302.1
  • Date Produced: March 2, 2023 6:55:33 PM UTC
  • Commit: 6b3afa7543dd5d69e621015cd1569fb0960b5f24
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
f215ee7 
…227.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23127.1
@dotnet-maestro dotnet-maestro bot requested review from a team as code owners February 28, 2023 16:26
ghost
ghost approved these changes Feb 28, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ryanbrandenburg
Copy link
Contributor

ryanbrandenburg commented Feb 28, 2023

Looks like it wants us to bump the analyzer versions.

@jaredpar jaredpar self-assigned this Feb 28, 2023
@jaredpar
Copy link
Member

jaredpar commented Feb 28, 2023

The way this target works, we're going to get a new warning every time the SDK updates

  <!-- Target to report a warning when SDK NetAnalyzers version is higher than the referenced NuGet NetAnalyzers version -->
  <Target Name="_ReportUpgradeNetAnalyzersNuGetWarning" BeforeTargets="CoreCompile" Condition="'$(_SkipUpgradeNetAnalyzersNuGetWarning)' != 'true' ">
    <Warning Text ="The .NET SDK has newer analyzers with version '$(_NETAnalyzersSDKAssemblyVersion)' than what version '$(_NETAnalyzersNuGetAssemblyVersion)' of 'Microsoft.CodeAnalysis.NetAnalyzers' package provides. Update or remove this package reference."
             Condition="'$(_NETAnalyzersNuGetAssemblyVersion)' != '' AND
                         '$(_NETAnalyzersSDKAssemblyVersion)' != '' AND
                          $(_NETAnalyzersNuGetAssemblyVersion) &lt; $(_NETAnalyzersSDKAssemblyVersion)"/>
  </Target>

Feel like we should just stop manually referencing this and take whatever the SDK is giving us. Is there a way to stop pinning the analyzers here and just use the default? Maybe just delete the package reference entirely.

dotnet-maestro bot and others added 2 commits March 1, 2023 08:36
@dotnet-maestro @jaredpar
Update dependencies from https://github.com/dotnet/arcade build 20230…
16cd0ba 
…228.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23128.1
@jaredpar
Respond to the arcade merge
35a2366 
This fixes up the repo to handle the incoming arcade merge.
@jaredpar jaredpar force-pushed the darc-main-1a9de2c4-14e4-4198-949d-cd99f4699486 branch from 7123f54 to 35a2366 Compare March 1, 2023 16:55
@jaredpar
Copy link
Member

jaredpar commented Mar 1, 2023

@dotnet/razor-compiler, @dotnet/razor-tooling PTAL at the following commit which is all the changes needed to get this arcade merge going green. Will add some context to the ones I feel are more questionable

35a2366

@jaredpar jaredpar mentioned this pull request Mar 1, 2023
Closed
jjonescz
jjonescz approved these changes Mar 1, 2023
View reviewed changes
src/Compiler/.editorconfig

# CA1305: Specify IFormatProvider
dotnet_diagnostic.CA1305.severity = warning
dotnet_diagnostic.CA1305.severity = none
Copy link
Member

@jjonescz jjonescz Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is unnecessary since it's already set in the root editorconfig? But anyways, don't we want to have it enabled? At least eventually.

Copy link
Member

@jaredpar jaredpar Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary though because this .editorconfig lists itself as a root so we don't actually consider the one above for files below.

@davidwengier davidwengier mentioned this pull request Mar 1, 2023
Merged
@jaredpar
Copy link
Member

jaredpar commented Mar 1, 2023

Sigh ... looks like the tests are hanging on Windows now. Debugging.

dotnet-maestro bot and others added 4 commits March 2, 2023 13:48
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
4a4705f 
…301.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23151.4
@RikkiGibson @jaredpar
Disable integration tests in 17.6
3522c42
@RikkiGibson @jaredpar
Fix yaml syntax error
05b63c3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
40422de 
…302.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23152.1
@jaredpar jaredpar merged commit eb56c96 into main Mar 3, 2023
@jaredpar jaredpar deleted the darc-main-1a9de2c4-14e4-4198-949d-cd99f4699486 branch March 3, 2023 19:37
@allisonchou allisonchou mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar left review comments

@davidwengier davidwengier davidwengier approved these changes

@jjonescz jjonescz jjonescz approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@jaredpar jaredpar

Labels

area-infrastructure type-dependency update 🔼

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ryanbrandenburg @jaredpar @davidwengier @jjonescz @RikkiGibson